Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest versions, add Scala 2.13 #5

Closed
wants to merge 4 commits into from

Conversation

JonathanKnight
Copy link

Hi I wanted to start to test Scala 2.13 with akka streams. I've updated the build.sbt to add Scala 2.13 and updated some dependencies.

@codecov
Copy link

codecov bot commented Apr 11, 2019

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #5   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files           4        4           
  Lines          63       63           
  Branches        4        4           
=======================================
  Hits           54       54           
  Misses          9        9
Impacted Files Coverage Δ
...dedetrich/akka/http/support/CirceHttpSupport.scala 100% <100%> (ø) ⬆️
...trich/akka/stream/support/CirceStreamSupport.scala 76.92% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867093d...2ec2390. Read the comment docs.

@mdedetrich
Copy link
Owner

Can you please the version to 0.4.0 since its a breaking API change? I am also on the fence about releasing this until Circe makes a stable 0.12.0 (in general I am a bit annoyed at Circe constantly breaking binary compatibility)

@mdedetrich
Copy link
Owner

Already done here #6

@mdedetrich mdedetrich closed this Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants